Added: Custom themes on user level & Styles improvements #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create struct to define the fields needed for a style to be serialized and used for the custom themes. * Add unit tests for serializing styles
* Define structures for styles and integrate them in UI components using default implementation temporally. * Define styles for editor with default values and use them in the editor widget.
* Provide styles definitions and default implementation for journals list then integrate the styles in journal list. * Converting styles: Initial style removes all modifiers to ensure styles don't inherit the modifiers from its parents in GUI hierarchy
* Definitions and default implementations for general styles. * Integrations of general styles in filter popup providing new styles for list highlight style when control is inactive.
* Apply general styles logic on entry popup and its tags popups as well to retain a unified style along the UI of the whole app.
* Add definitions for message box colors with default values * Integrate message box colors in UI
* Provides cli commands to print path & default styles and to write the default styles to the path of the themes. * Remove async from method signature since it doesn't need it. * Module for desrializing & combining themes, still as placeholder without implementation.
* Deserialize themes from text in toml format, adding missing themes from the default colors. * Combining styles from defaults led to refactoring in default values of the style groups. * Provide unit tests to cover all cases of themes.
* Styles needs to be read and validated before enabling raw mode on terminal to ensure the error message isn't distorted. * Improve error message extending it with the path of styles file.
* Add document to explain how custom theming works. * Update the readme file referencing the themes file and updating help output on CLI. * Add missing install nodes to table of content of README file. * Fix small alignment issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #509
It provides a complete framework to enable users to override the styles and colors of the app.
This PR includes:
themes.tomlfile intui-journaldirectory within the config directory (More in themes documentations)Themes.mdDocument to explain theming in details.