Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to see old versions of a Shader. #12

Open
bhouston opened this issue Aug 18, 2015 · 3 comments
Open

Ability to see old versions of a Shader. #12

bhouston opened this issue Aug 18, 2015 · 3 comments

Comments

@bhouston
Copy link

Each save should increment a version number and one should be able to see old versions of a shader and possibly fork from one.

@bhouston
Copy link
Author

This is relatively easy to implement. Just keep around every single script submitted, its date/time submitted, its version number (incrementing from the previous version) and its owner "shader." The current "shader" record would point to the current entries for the vertex and fragment shader. You could access old ones by entering the url:
http://shaderfrog.com/app/view/{shaderId}/revision/{revisionNumber}

@AndrewRayCode
Copy link
Owner

I'm wondering if there should be a distinction between "save" and "publish" (for a published shader) - where saving it does not updated the published version - but publishing it would update the version in the history. Would that work here, or do you want a full history for every save (including private shaders?)

@bhouston
Copy link
Author

I think nothing is lost by having a full history.

Most people will want to have published the most recent version. Publishing an older version is advanced, and while I can see that being useful, I think it presents some complexities that may not be initially needed. I think people can work around having the most recent published by forking to temp shaders, developing new versions and cutting and pasting back into the main line or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants