Add additional Filter-Hooks #3
Conversation
| foreach($fields as $key =>$item) { | ||
|
|
||
| if(in_array((string)$key, $this->get_excluded_fields()) ){ | ||
| continue; | ||
| } else { | ||
|
|
||
|
|
||
| $item = apply_filters('ysacf_field_overwrite', $key, $item, $pid); |
There was a problem hiding this comment.
The parameter order here is wrong. You should always filter the first parameter in an apply_filters call. I.e. $key and $item should switch place. This makes also makes the filter on line 70 unnecessary.
I also think it would be better for both performance and usability to filter all the fields at once before the loop instead of filtering every field individually.
Would it work for your use case if you put the filter in the ajax_get_fields method and filter the $fields variable?
| @@ -66,6 +66,15 @@ function __construct(){ | |||
| add_action( 'admin_print_scripts-post-new.php', array($this, 'enqueue_admin_scripts') , 999 ); | |||
| add_action( 'admin_print_scripts-post.php', array($this, 'enqueue_admin_scripts'), 999 ); | |||
| add_action( 'wp_ajax_' . $this->plugin_slug . '_get_fields', array($this, 'ajax_get_fields') ); | |||
|
|
|||
| add_filter('ysacf_field_overwrite', function($key, $item, $postID) { | |||
There was a problem hiding this comment.
This does not make sense. See comment on line 106.
| return $item; | ||
| }, 1, 3); | ||
|
|
||
| add_filter('ysacf_finalize', function($data, $postID) { |
There was a problem hiding this comment.
This filter hook does nothing and can be removed.
composer.json
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "all3dp/Yoast-SEO-ACF-Content-Analysis", | |||
There was a problem hiding this comment.
Should be Angrycreative/Yoast-SEO-ACF-Content-Analysis
Update package name for compatibility reason
Hello Angrycreative Team,
thanks for the great work on this plugin! We would like to have additional filter hooks in the plugin.
The reason we need this is because some of the output of our ACF fields depend on conditional logic within ACF and will affect the keyword density calculation as well as keyword suggestions.
Therefor we introduced two new filter one is for modifying the ACF field values and the other one is to control the final output that get's send back to the Yoast SEO backend.
What do you think?
Thanks,
Alex