Fix C++ warnings due to missing default cases in switch statements #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
added a commit
to anchpop/Clipper2
that referenced
this pull request
Oct 1, 2024
This reverts commit 304235b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some C++ compilers give warnings when not the default case is not covered in a switch statement over an
enum class. Since Clipper2 sets -Werror, this causes builds to fail on these compilers when using it as a dependency through cmake'sadd_subdirectory. See GCC's -Wswitch-default docs.Thank you for the great library by the way - been using it since the Clipper1 days.