Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to fix security issues within sub-dependencies #375

Conversation

gligorkot
Copy link
Contributor

Fixes #374

@gligorkot gligorkot marked this pull request as draft August 30, 2024 02:15
@gligorkot gligorkot marked this pull request as ready for review August 30, 2024 02:26
@gligorkot
Copy link
Contributor Author

gligorkot commented Aug 30, 2024

@jayair, hope this is all good. I only upgraded the necessary dependencies to get the reported vulnerabilities back down to 0. It required quite a few test updates, so please have a look at those and merge at your convenience.

Regarding the node14.x tests failure - please let me know what you'd like to do. I'm tempted to drop support for both 14 and 16 as AWS Lambda doesn't support these runtimes anymore anyways.

@gligorkot gligorkot mentioned this pull request Aug 30, 2024
@jayair
Copy link
Member

jayair commented Sep 2, 2024

Yeah let's drop it. If you fix the test let me know, I'll cut a release.

@gligorkot
Copy link
Contributor Author

@jayair all good. Dropped 14 and 16, CI should all pass now. Only thing that fails is the Label check, but I have no permissions to add labels, so that might have to be done by someone with permissions 🙏

@jayair jayair added the bug Something isn't working label Sep 2, 2024
@jayair
Copy link
Member

jayair commented Sep 2, 2024

Thanks!

@jayair jayair merged commit 59cb064 into AnomalyInnovations:master Sep 2, 2024
3 of 4 checks passed
@jayair
Copy link
Member

jayair commented Sep 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies
2 participants