Optimize expensive get_imported_functions_size function.

AntelopeIO · Oct 23, 2024 · 20143cb · 20143cb
1 parent a45ee4e
commit 20143cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/include/eosio/vm/types.hpp b/include/eosio/vm/types.hpp
@@ -337,8 +337,10 @@ namespace eosio { namespace vm {
       template<typename Imports>
       static uint32_t get_imported_functions_size_impl(const Imports& imports) {
          uint32_t number_of_imports = 0;
-         for (uint32_t i = 0; i < imports.size(); i++) {
-            if (imports[i].kind == external_kind::Function)
+         const auto sz = imports.size();
+         const auto data = imports.data(); // to avoid the unnecessary size check since we iterate from 0 to sz
+         for (uint32_t i = 0; i < sz; i++) {
+            if (data[i].kind == external_kind::Function)
                number_of_imports++;
          }
          return number_of_imports;

diff --git a/include/eosio/vm/wasm_stack.hpp b/include/eosio/vm/wasm_stack.hpp
@@ -34,7 +34,7 @@ namespace eosio { namespace vm {
             if (_index >= _store.size())
                _store.resize(_store.size()*2);
          }
-         _store[_index++] = std::forward<ElemT>(e);
+         _store[_index++] = std::move(e);
       }
 
       ElemT pop() { return _store[--_index]; }