-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ort v2 BREAKING #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.
Maybe we can dynamic linking mentioned here. Reference from FastEmbed-go https://github.com/Anush008/fastembed-go/blob/7fe735ed91f0d510ce07b58c6d5dd5ae31fb0218/.github/workflows/release.yml#L30-L34 For |
Cargo.toml
Outdated
@@ -16,7 +16,7 @@ anyhow = { version = "1.0" } | |||
flate2 = { version = "1.0" } | |||
minreq = { version = "2.10", default-features = false, features = ["https-rustls"] } | |||
ndarray = { version = "0.15", default-features = false } | |||
ort = { version = "1", features = ["load-dynamic"] } | |||
ort = { version = "2.0.0-alpha.4", features = ["load-dynamic"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Libraries should only enable features they need.
[dependencies]
ort = { version = "2.0.0-alpha.4", default-features = false, features = [ "ndarray" ] }
[dev-dependencies]
ort = "2.0.0-alpha.4"
@Anush008 btw, 7e0526a has a critical performance fix. @joshniemela and I found that |
#9 is probably also related to this PR |
Indeed it significantly improves #9.
|
Is it possible to do a test on python as well on the same machine? |
|
# [1.11.0](v1.10.0...v1.11.0) (2024-01-08) ### Features * ort v2 BREAKING ([#12](#12)) ([36573a8](36573a8)) ## [1.11.0](v1.10.0...v1.11.0) (2024-01-08) ### 🍕 Features * ort v2 BREAKING ([#12](#12)) ([36573a8](36573a8))
🎉 This PR is included in version 1.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Bummer. Should've been a major release. |
@joshniemela, @decahedron1 Thanks for the efforts. Super grateful. This is amazing. |
# [2.0.0](v1.11.0...v2.0.0) (2024-01-08) ### Features * ort v2 ([a6b5f55](a6b5f55)) * ort v2 ([dca1f86](dca1f86)) * ort v2\n\nBREAKING CHANGE: #12 ([1128471](1128471)) ### BREAKING CHANGES * #12 ## [2.0.0](v1.11.0...v2.0.0) (2024-01-08) ### ⚠ BREAKING CHANGES * #12 ### 🍕 Features * ort v2 ([a6b5f55](a6b5f55)) * ort v2 ([dca1f86](dca1f86)) * ort v2\n\nBREAKING CHANGE: #12 ([1128471](1128471))
After some commit slogging, it is finally up. I've yanked |
Thank you for the perf enhancements, but the ONNX runtime upgrade needs to be notated. This should be released as v2.0.0-alpha or with some other indication that it is not a stable release since it depends on an alpha version of ONNX runtime. |
ort v2.0.0-alpha.4 uses ONNX Runtime v1.16.3, so only a minor upgrade as ort 1.16 uses 1.16.0. It does not use an alpha version of ONNX Runtime. |
Thank you for correcting that the crate is alpha, not the actual runtime. Nevertheless, this release is not stable and should indicate such in its versioning. P.S. I think its really awesome that you are maintaining this crate for the community! I'm just trying to help :). |
Migrated the code to ort to 2.0.0 based on the breaking API changes
Changed padding strategy and wrote a sequential version of
query_embed
, this gives a speedup of 95%