Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue60 #61

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix issue60 #61

merged 2 commits into from
Oct 12, 2023

Conversation

peter-csala
Copy link
Contributor

Related issue

Fix 1

  • Specified SamplingDuration to 2 seconds instead of relying on the default 30 seconds
  • Impacted demos:
    • Demo06, AsyncDemo06
    • Demo07, AsyncDemo07
    • Demo08, AsyncDemo08

Fix 2

  • The order of the strategy registration were screwed up in several places
  • I've corrected the order
  • Impacted demos:
    • Demo07, AsyncDemo07
    • Demo08, AsyncDemo08
    • Demo09, AsyncDemo09

@martincostello martincostello linked an issue Oct 12, 2023 that may be closed by this pull request
circuitBreakerStrategy never opens #60
Closed
@martincostello martincostello merged commit 22b5c78 into App-vNext:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circuitBreakerStrategy never opens
2 participants
@peter-csala @martincostello