Multiserver: discord webhook #2663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to leave the comment, we probably just have it disabled from custom server with some sort of admin command that you can use for the big async? i know people would love to have that, though the channel it'll log to will probably end up mostly unusable, it'll at least be searchable. i wouldn't be surprised if that alone greatly exceeded the rate limiting though. |
Berserker66
commented
Jan 4, 2024
alwaysintreble
added
is: enhancement
PoryGone
added
the
waiting-on: peer-review
Exempt-Medic
added
the
waiting-on: author
qwint
approved these changes
Jul 27, 2024
Exempt-Medic
removed
the
waiting-on: author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds support for Discord WebHook into MultiServer
I tried the Async version, but it seems to block the asyncio loop it's attached to while waiting on a response, so instead of bothering with a threaded asyncio loop I just wrote an explicit thread, I prefer it that way.
How was this tested?
On a private discord.
Since rate limiting is per-IP, this will probably be unusable on archipelago.gg if it's popular, which is fine, maybe it's worthwhile to look into a way to disable this command via webhost config.
If this makes graphical changes, please attach screenshots.