LADX: enable deathlink #3828
LADX: enable deathlink #3828
Conversation
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
was failing to initialize from slot data, also took the opportunity to set up for nicer merge with magpie slot data PR
kill with damage rather than setting hp to zero in order to trigger medicine, also refunds trade items on deathlink if they were used but the player died before getting the check
There was a problem hiding this comment.
not a programmer. did a game earlier tonight and at first it failed. a quick adjustment and it worked just fine. based on the latter version, deathlink works. its as annoying as it should be. i killed the hardhit beetle and during its death animation i got killed by deathlink so i had to refight it. which feels like how it should be tbh. i approve of this change to be added.
There was a problem hiding this comment.
I have participated in two asyncs and one sync testing the new deathlink functionality. I can confirm that I properly received deaths from others in the sync and perhaps once in the asyncs, but even in the asyncs it did indicate within the text client that a death was being sent on the rare occasion I did die.
As for the code itself, I am hardly a Python expert and I know essentially nothing to speak of in terms of the LADX integration specifically. That said, I did look over the code and I do not see anything egregiously wrong with the code. It appears to be fairly self-explanatory considering I could still generally follow the thought processes even if I didn't necessarily always have the full context. I also see where they addressed a bug encountered in an earlier beta version where dying during the trade item swap would lose you an item (I think this may have actually happened to me during the sync, but it's been a while so my memory is foggy).
Overall, I see no reason not to merge this PR into main.
There was a problem hiding this comment.
This PR was tested as part of a Beta apworld that was used in three dedicated Test Asyncs, as well as dozen of normal Syncs. I have also personally run 200 test generations which succeeded.
We have also done polling on what users want, etc. which can be found here
The new feature has worked as expected and other stuff does not seem impacted.
In the beginning there was a hiccup with Death Links occuring during trade quests but the fix works flawlessly. After that, no more issues happened.
Exempt-Medic
added
waiting-on: core-review
Co-authored-by: Exempt-Medic <[email protected]>
|
found a major bug, drafting until fixed |
Exempt-Medic
added
waiting-on: author
What is this fixing or adding?
Adds deathlink support to LADX. There was already existing work on it but it wasn't quite finished. This also adds a command to the client for toggling deathlink.
How was this tested?
Tested sending and receiving deathlinks in a few multiworlds.