Core: KivyMD and Launcher overhaul #3934
Conversation
|
some other small things ive noticed while using this branch |
I doubled the movement on each scroll wheel tick, but we can probably adjust that one to taste with a proper beta version. The "not scrolling by click and drag" was intentional because of some weirdness with it, but I think this is more an issue of the base KivyMD scroll effect. Gonna mess with it some and see if I can't just swap in the base Kivy version.
Fixed, to the point we don't even need the |
|
code and functionality looks good on first blush, will test a bit more extensively later |
|
FYI the imageloader stuff in #3629 does require use of the ApAsyncImage class in kvui instead of AsyncImage directly, else it should be plug and play |
| @@ -58,8 +60,9 @@ class Component: | |||
| def __init__(self, display_name: str, script_name: Optional[str] = None, frozen_name: Optional[str] = None, | |||
| cli: bool = False, icon: str = 'icon', component_type: Optional[Type] = None, | |||
| func: Optional[Callable] = None, file_identifier: Optional[Callable[[str], bool]] = None, | |||
| game_name: Optional[str] = None, supports_uri: Optional[bool] = False): | |||
| game_name: Optional[str] = None, supports_uri: Optional[bool] = False, description: Optional[str] = None): | |||
There was a problem hiding this comment.
Why not make description non-optional and set the default to ""? Seems like it would save a few characters and simplify the type.
There was a problem hiding this comment.
at least one argument against doing this is that this would make it so that if anyone modified the description without replacing it, it'd change it for all components using the default, so this is good practice for the intention.
There was a problem hiding this comment.
Python strings are immutable, though, it's impossible to modify without replacing.
What is this fixing or adding?
Shifts the contents of
kvui.py, and thus all CommonClient-based clients as well as Launcher, to using KivyMD. KivyMD is an extension for Kivy that is almost fully compatible with pre-existing Kivy components, while providing Material Design support for theming and overall visual design as well as useful pre-existing built in components such as Snackbars, Tooltips, and a built-in File Manager (not currently being used).As a part of this shift, the launcher was completely overhauled, adding the ability to filter the list of components down to each type of component, the ability to define favorite components and filter to them, and add shortcuts for launcher components to the desktop. An optional description field was added to Component for display within the new launcher.
The theme (Light/Dark) and primary palette have also been exposed to users via client/user.kv.
How was this tested?
Manually, across the span of numerous unsupported games. I'm considering putting out a pre-release version for wider testing as well.
The Launcher changes were tested manually, both in a frozen build and on source.
If this makes graphical changes, please attach screenshots.
Launcher - Dark/Green
Launcher - Light/Lavenderblush
Launcher - Dark/Violet
Text Client - Dark/Red
Text Client - Dark/Cyan
