MLSS: Add new goal + Update basepatch to standalone equivalent #4409
+231
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
qwint
suggested changes
Jan 21, 2025
There was a problem hiding this comment.
i'm only really "requesting changes" for is the line in generate_early where you don't set the value of emblems_amount, the rest is mostly code readability and style suggestions
Pure code review, did not run any gens/tests/games/etc., also did not review the basepatch change nor do I have the context to review the actual logic/patching changes past the code
qwint
approved these changes
Jan 21, 2025
|
friend tested the patch changes by playing through a seed with the new option, everything seemed good and the new goal worked as we expected |
Exempt-Medic
added
the
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds a new goal, Emblem Hunt. Collect a number of emblems to unlock a different way to get to the final area of the game.
Adds many bugfixes over the coarse of a few months with an updated basepatch. Basepatch also adds mechanics related to the new goal.
All assembly changes based on v1.10 of the standalone randomizer jamesbrq/MLSSRandomizer@v1.9.13...main
How was this tested?
Changes to basepatch tested in standalone randomizer. Generated and patched game successfully. No complaints from unsupported apworld out in the wild.