-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timespinner: Add Boss Rando Type Options #4466
base: main
Are you sure you want to change the base?
Conversation
worlds/timespinner/Options.py
Outdated
@@ -418,6 +469,11 @@ class TimespinnerOptions(PerGameCommonOptions, DeathLinkMixin): | |||
trap_chance: TrapChance | |||
traps: Traps | |||
|
|||
class HiddenBossRandoOverrides(BossRandoOverrides): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this a new setting you dont need to add it to the BackwardsCompatiableTimespinnerOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool I was wondering about that
14a8973
to
d514745
Compare
… into ts-boss-rando-options
Did you consider using PlandoBosses instead? |
I had not, mostly because I was not aware of its existence. I'll have to look at it to make sure it can work with how the client expects things to work |
After looking into it further I'm not sure if PlandoBosses would be a good fit for this. The client is the one responsible handling the different options at runtime, so we can't determine the order of bosses at generation time like other games that use PlandoBosses |
Well, the client only does what the server told it todo, so we could generate bosses at generation time and just put the selected bosses in the slot_data and it will work just fine |
Ah ok, so do you think I should go ahead and use PlandoBosses for this? |
when i though about adding the boss configuration to AP i did also think PlandoBosses would be a good way todo it, but at the same time i think it wont work for TImespinner because it allows some things like selecting what boss in what room and we dont offer that |
Ah, is that different than saying what boss you get teleported to when you enter a specific boss location? That was going to be my plan, to fill in the locations list with the names of the bosses so it maps similarly to the client. |
What is this fixing or adding?
Adding in the Boss Rando Type options that were added to the base randomizer a few versions ago so that they can be controlled via yaml.
How was this tested?
Manually generated seeds for each option type and verified in the Bestiary and Options screens that the expected setting was applied. Also manually verified that swapping between the seeds while the game was still open properly applied the options to each seed.