Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wargroove: Add Linux support to WargrooveClient #4526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Wargroove: Add Linux support to WargrooveClient #4526

wants to merge 1 commit into from
+68 −25

Conversation

Raspberryfloof
Copy link

What is this fixing or adding?

  • Adds Linux support for the Wargroove Client by adding a new setting value ("save_directory") used for locating the Wargroove game save directory.
  • Cleans up the error messages displayed when the Wargroove Client fails to find its required files or the game files.
  • Changes use of deprecated Utils.get_options call to the newer settings API.

How was this tested?

  • Tested on Linux (fully tested, including playing through a seed successfully and testing each potential failure path)
  • Tested in Windows VM (tested that client launches and finds correct data directories, and tested each potential launch failure path. Wargroove does not launch in a VM, so could not test gameplay)

If this makes graphical changes, please attach screenshots.

  • n/a

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 21, 2025
qwint
qwint reviewed Jan 21, 2025
View reviewed changes
WargrooveClient.py
@@ -78,31 +79,58 @@ def __init__(self, server_address, password):
self.syncing = False
self.awaiting_bridge = False
# self.game_communication_path: files go in this path to pass data between us and the actual game
game_options = settings.get_settings()["wargroove_options"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI i believe it is recommended to use settings.get_settings().wargroove_options (and then subsequently game_options.save_directory) because they are properly typed

@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 21, 2025
@FlySniper
Copy link
Collaborator

Looks like the Wargroove docs need updating. They currently reflect that Wargroove is Windows only. I made a PR with some suggestions: Raspberryfloof#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwint qwint qwint left review comments

@FlySniper FlySniper Awaiting requested review from FlySniper

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raspberryfloof @FlySniper @qwint @Exempt-Medic