Bizhawk Client: Display Err #4532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
beauxq
reviewed
Jan 21, 2025
worlds/_bizhawk/context.py
Outdated
Comment on lines
239
to
241
| except Exception as exc: | ||
| logger.exception(exc) | ||
| return {} | ||
| except Exception as e: | ||
| Utils.messagebox('Error', str(e), True) | ||
| raise |
There was a problem hiding this comment.
Even with a message box, I think it's still important for the exception with the full stack trace to go in the text file log.
I don't know whether this raise does that.
Did you make sure the full stack trace still goes in the text file log?
There was a problem hiding this comment.
I can check that later tonight
ScipioWright
added
the
is: enhancement
Zunawe
reviewed
Jan 22, 2025
Co-authored-by: Bryce Wilson <[email protected]>
Zunawe
approved these changes
Jan 22, 2025
Zunawe
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Causes the Bizhawk client to display an error popup when an Exception is raised, similarly to SNIClient
How was this tested?
I have an in-development APWorld using Bizhawk Client that raises an exception if a version check patched into the rom does not match world's version when the user applies the patch. The error message appeared as expected. I also tested to make sure that the error was still logged correctly, and that a game could still connect and be played.
If this makes graphical changes, please attach screenshots.