OOT: add dungeon->boss/prize mapping into slotdata #4541
+53
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed single to double-quotes - removed keyword from function-call - uses f-string instead of concat. - add trailing comma
…sets and collectible_override_flags in because they were there before all the other changes and i have no idea if they are needed
github-actions
bot
added
the
waiting-on: peer-review
|
the slot_data containing collectible_override_flags and collectible_flag_offsets was there before my first addition to slotdata so leaving that out of the added race check. to not have duplicate code and an else in that check i also left in the empty lists for bosses and prizes. |
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Add a new mapping for dungeon->boss and dungeon->prize into slotdata so the Poptracker packs can read it
How was this tested?
Generated multiple seeds with the changes and read/confirmed the newly created slotdata with Poptracker console output.
Split from 4464 to separate discussions and possibility to be merged
info added here, mapping dungeon to boss and reward, would only be shown if the player has the knowledge to legally obtain these infos in-game which is done in the tracker pack itself. So no unfair advantage in a competitive setting granted here.