Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KH2: Deterministic entrances by using tuples instead of sets #4548

Merged
merged 1 commit into from
Jan 27, 2025
Merged

KH2: Deterministic entrances by using tuples instead of sets #4548

merged 1 commit into from
Jan 27, 2025

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

#4410
Fixes the KH2 error from non-deterministic entrance orders.

How was this tested?

Unit tests and the tests in 4410.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 24, 2025
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 24, 2025
@Mysteryem Mysteryem mentioned this pull request Jan 24, 2025
Open
8 tasks
Jouramie
Jouramie approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@Jouramie Jouramie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I checked and those are the only sets present in this file.

@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 26, 2025
@JaredWeakStrike
Copy link
Collaborator

lgtm

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 27, 2025
@Exempt-Medic Exempt-Medic merged commit 8c5592e into ArchipelagoMW:main Jan 27, 2025
16 checks passed
@Exempt-Medic Exempt-Medic deleted the kh2-determinism branch January 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Jouramie Jouramie Jouramie approved these changes

@JaredWeakStrike JaredWeakStrike Awaiting requested review from JaredWeakStrike

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exempt-Medic @JaredWeakStrike @Jouramie @NewSoupVi