Pokemon Emerald: Clean up free fly blacklist #4552
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: enhancement
Jouramie
approved these changes
Jan 26, 2025
|
Default values on the blacklist, or on the yaml as a whole? The blacklist code doesn't run if free fly location isn't enabled, which I forgot when I first ran it to test. |
|
With the default blacklist, I mean. I did enable the free fly location so it did run. |
ScipioWright
approved these changes
Jan 27, 2025
ScipioWright
added
waiting-on: core-review
Exempt-Medic
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Cleans up what was added in #4165 and adds sphere 1 fly locations as default-blacklisted options.
How was this tested?
Generated and checked the free fly location in the debugger.