Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhost: Update random option wording on webhost #4555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Webhost: Update random option wording on webhost #4555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WebHostLib/templates/playerOptions/macros.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
{% endmacro %}

{% macro RandomizeButton(option_name, option) %}
<div class="randomize-button" data-tooltip="Toggle randomization for this option!">
<div class="randomize-button" data-tooltip="Pick a random choice for this option.">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For range option, I think it does not really make sense to pick a "choice". One could argue that all possible values are a choice, but I think it would make more sense (to my non-native English speaker mind) to call it directly a value, as that would also fit choice options.

Suggested change
<div class="randomize-button" data-tooltip="Pick a random choice for this option.">
<div class="randomize-button" data-tooltip="Pick a random value for this option.">

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think using "value" might make it more confusing to some vs choice? But it's sorta vibes based, so idk. If someone else chimes in too and says value better I'll probably change it

<label for="random-{{ option_name }}">
<input type="checkbox" id="random-{{ option_name }}" name="random-{{ option_name }}" class="randomize-checkbox" data-option-name="{{ option_name }}" {{ "checked" if option.default == "random" }} />
🎲
Expand Down
Loading