Stardew Valley: add assert_reach_region_* for better tests #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
approved these changes
Jan 26, 2025
agilbert1412
added
is: refactor/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
assert_reach_region_*to more easily assert that a region can be reached from a given state. Will help with this comment Stardew valley: Fixed Aurora Vineyard tablet logic #4512 (comment).strfor location name toassert_reach_location_*, so we do not need to find the location in the multiworld to assert on it.How was this tested?
Not used yet, so not tested.
If this makes graphical changes, please attach screenshots.
N/A