-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timespinner: support new flags and settings from the randomizer #4559
Open
sgrunt
wants to merge
12
commits into
ArchipelagoMW:main
Choose a base branch
from
sgrunt:ts-new-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+167
−23
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c349606
Timespinner: Add "no hell spiders" enemy rando option that is present…
5f327b1
Timespinner: Prism Break support tweaks (including tracker support)
e546a28
Timespinner: Add support for upstream Lock Key Amadeus flag
0799321
Timespinner: Add support for upstream Risky Warps flag
f1f1e9f
Timespinner: Add support for upstream Pyramid Start flag
0ec28c8
Timespinner: fix error in lab connectivity logic
6717be6
Timespinner: use has_all to simplify one check
sgrunt 21f6c6e
Timespinner: fix apparent logic error inherited from in-rando logic
1333275
Timespinner: adjust "Origins" location logic slightly further to acco…
1d08ab1
Timespinner: remove the backward compat options for the recent flag a…
7565ae4
Timespinner: add newly added Gate Keep option from rando
2894621
Timespinner: adjust the laser access colours in the tracker
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,11 +52,12 @@ def __init__(self, options: TimespinnerOptions, random: Random): | |
self.flood_lab = False | ||
|
||
self.pyramid_keys_unlock, self.present_key_unlock, self.past_key_unlock, self.time_key_unlock = \ | ||
self.get_pyramid_keys_unlocks(options, random, self.flood_maw, self.flood_xarion) | ||
self.get_pyramid_keys_unlocks(options, random, self.flood_maw, self.flood_xarion, self.flood_lab) | ||
|
||
@staticmethod | ||
def get_pyramid_keys_unlocks(options: TimespinnerOptions, random: Random, | ||
is_maw_flooded: bool, is_xarion_flooded: bool) -> Tuple[str, str, str, str]: | ||
is_maw_flooded: bool, is_xarion_flooded: bool, | ||
is_lab_flooded: bool) -> Tuple[str, str, str, str]: | ||
|
||
present_teleportation_gates: List[str] = [ | ||
"GateKittyBoss", | ||
|
@@ -85,10 +86,15 @@ def get_pyramid_keys_unlocks(options: TimespinnerOptions, random: Random, | |
if not is_maw_flooded: | ||
past_teleportation_gates.append("GateMaw") | ||
|
||
if not is_xarion_flooded: | ||
present_teleportation_gates.append("GateXarion") | ||
if options.risky_warps: | ||
past_teleportation_gates.append("GateLakeSereneLeft") | ||
present_teleportation_gates.append("GateDadsTower") | ||
if not is_xarion_flooded: | ||
present_teleportation_gates.append("GateXarion") | ||
if not is_lab_flooded: | ||
present_teleportation_gates.append("GateLabEntrance") | ||
|
||
if options.inverted: | ||
if options.inverted or (options.pyramid_start and not options.back_to_the_future): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Strictly speaking this doesn't match the in-randomiser logic (which will allow both past and present for pyramid start mode based on my understanding), but generation tends to fail out if I don't restrict this case to present gates. |
||
all_gates: Tuple[str, ...] = present_teleportation_gates | ||
else: | ||
all_gates: Tuple[str, ...] = past_teleportation_gates + present_teleportation_gates | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three colours are the same as those used by the randomiser's item tracker for the three Laser Access items.