Stardew Valley: Add test decorators to ensure all mods are tested once #4560
+124
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove total performance and performance on individual tests for threading purposes
Co-authored-by: Jouramie <[email protected]>
Jouramie
force-pushed
the
StardewValley/add-decorators-to-ensure-all-mods-are-tested-once
branch
from
d10574e to
a1bad3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Supersedes #4557
This creates two decorators to be used on a test class and a test method. They are designed to ensure that those tests are not forgotten when adding a new mod. If a mod in added with
@testing_modor in theexcluded_modsparameter of@must_test_all_mods, the tests will fail in thetearDownClassof the test class.This will enable unrolling the other mod tests, now that we can ensure maintainability is not hurt.
How was this tested?
Yes
If this makes graphical changes, please attach screenshots.
N/A