MM2: fix plando and weakness special cases #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: bug/fix
Seatori
reviewed
Jan 27, 2025
| @@ -175,7 +175,7 @@ class WeaknessPlando(OptionDict): | |||
| display_name = "Plando Weaknesses" | |||
| schema = Schema({ | |||
| Optional(And(str, Use(str.title), lambda s: s in bosses)): { | |||
| And(str, Use(str.title), lambda s: s in weapons_to_id): And(int, lambda i: i in range(-1, 14)) | |||
| And(str, Use(str.title), lambda s: s in weapons_to_id): And(int, lambda i: i in range(-1, 15)) | |||
There was a problem hiding this comment.
What exactly is the point of changing the maximum to 15?
There was a problem hiding this comment.
Python ranges are end-exclusive, so 14 wasn't actually a valid option.
Berserker66
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Two issues:
plando_weaknesswas completely nonfunctional due to not converting the strings found in the yaml to their int counterpartsHow was this tested?
Seed 89649562947386879912 on a default yaml with
random_weakness: shuffled. On current main, Atomic Fire is picked up before moving past Wily Stage 4, with this change Metal Blade is required instead.Plando was tested with the following plando.
If this makes graphical changes, please attach screenshots.