Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meritous: move completion_condition to set_rules #4567

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

FelicitusNeko
Copy link
Collaborator

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Moves completion_condition to set_rules as requested by #4563.

How was this tested?

Ran unit tests.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 28, 2025
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jan 28, 2025
@Berserker66 Berserker66 merged commit 57afdfd into ArchipelagoMW:main Jan 29, 2025
16 checks passed
@FelicitusNeko FelicitusNeko deleted the meritous-fix-20250128 branch January 29, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants