Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ClientMessages to nxproxy side #1016

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

uli42
Copy link
Member

@uli42 uli42 commented May 16, 2021

This should help with clients requesting window manager actions like
maximizing or minimizing. This is a first version as it only handles
messages of type WM_STATE_CHANGE and _NET_WM_STATE. But ICCCM and EWMH
know some more.

The other direction, setting of properties by the WM, is already
implemented in Rootless.c.

Fixes #1015

@sunweaver
Copy link
Member

@uli42: is this PR (#1016) ready to be merged? You didn't put any reviewer. Please add me as reviewer, if this one is good to go.

@uli42
Copy link
Member Author

uli42 commented Jun 7, 2021

This is not perfect as there might be more cases to handle. But it was/is sufficient to handle @Dimbor's case. Should be revisited one day, but the current state should be merged.

@uli42 uli42 requested a review from sunweaver June 7, 2021 18:31
Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should help with clients requesting window manager actions like
maximizing or minimizing. This is a first version as it only handles
messages of type WM_STATE_CHANGE and _NET_WM_STATE. But ICCCM and EWMH
know some more.

The other direction, setting of properties by the WM, is already
implemented in Rootless.c.

Fixes ArcticaProject#1015
@sunweaver sunweaver merged commit c3476b6 into ArcticaProject:3.6.x Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tricky minimize/maximize/restore things in rootless
2 participants