muvm: remove RAM special case for 8GB machines #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that muvm is able to request the guest to decrease its file cache and the root cause for the premature OOM has been indentified, let's remove the check for 8GB machines that limited the microVM to be smaller than 5GB, and just set it to be 80% of the host RAM, just as we do with systems with other configurations. In practice, this enables 8GB machines to run more games out of the box (tested with multiple Steam games on a MacBook Air M1 with 8GB). Signed-off-by: Sergio Lopez <[email protected]>
slp
requested review from
teohhanhui,
alyssarosenzweig,
asahilina and
WhatAmISupposedToPutHere
as code owners
asahilina
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that muvm is able to request the guest to decrease its file cache and the root cause for the premature OOM has been indentified, let's remove the check for 8GB machines that limited the microVM to be smaller than 5GB, and just set it to be 80% of the host RAM, just as we do with systems with other configurations.
In practice, this enables 8GB machines to run more games out of the box (tested with multiple Steam games on a MacBook Air M1 with 8GB).