Support empty DISPLAY in xauth #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently x11bridge is broken on Gnome, because Gnome seems to create the wildcard entry in xauth with an empty DISPLAY, and x11bridge then filters it out, resulting in an empty xauth file. This makes x11bridge accept the Gnome entry, fixing X11.
ah-
requested review from
slp,
teohhanhui,
alyssarosenzweig,
asahilina and
WhatAmISupposedToPutHere
as code owners
|
Superseded by #129 |
|
This might be just a formality, but this PR was submitted 5 minutes before #129. So personally I think we should rather say, I'm sorry that we missed this PR and stacked our approvals on the other one instead, even though the change was exactly the same. |
|
Oops, you're right, @teohhanhui. Sorry @ah-, we should have reviewed and merged this one instead of #129. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently x11bridge is broken on Gnome, because Gnome seems to create the wildcard entry in xauth with an empty DISPLAY. For example:
x11bridge then filters it out, resulting in an empty xauth file.
This makes x11bridge accept the Gnome entry, fixing X11.
I searched around a bit why Gnome is doing this, only thing I could find is https://xorg.freedesktop.narkive.com/zzRJsYVZ/is-xauth-entry-without-display-number-valid.