Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for the pt => px conversion section #140

Closed
wants to merge 1 commit into from
Closed

Update for the pt => px conversion section #140

wants to merge 1 commit into from

Conversation

ArnaudDelafosse
Copy link
Contributor

@ArnaudDelafosse ArnaudDelafosse commented Feb 22, 2018 •
edited by dzc34
Loading

Tried my best to keep it clear for users, feel free to modify at will or completely ignore :)
Also did a couple of syntax corrections and made the titles match the app labels for clarity.

I verified my work is based on develop branch

  • yes, keep going

@ArnaudDelafosse
Update for the pt => px conversion section
1956673 
Tried my best to keep it clear for users, feel free to modify at will or completely ignore  :)
Also did a couple of syntax corrections and made the titles match the app labels for clarity.
@dzc34 dzc34 requested a review from mfaure February 23, 2018 07:13
@dzc34
Copy link
Member

dzc34 commented Feb 23, 2018

related to #136

@dzc34 dzc34 mentioned this pull request Feb 25, 2018
Open
@dzc34 dzc34 mentioned this pull request Feb 25, 2018
Merged
1 task
@dzc34 dzc34 removed the request for review from mfaure February 25, 2018 20:08
@dzc34 dzc34 mentioned this pull request Feb 25, 2018
Merged
1 task
dzc34
dzc34 reviewed Feb 25, 2018
View reviewed changes
documentation/en/Howto-use.md

### Other info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not agree: "Other info" is part of "Minimum ratio"

@dzc34
Copy link
Member

dzc34 commented Feb 25, 2018 •
edited
Loading

Thanks @ArnaudDelafosse for your contributing!
I splited your merge request in two part for more easy review:

#142 is now merged in develop branch.

Only one change was not include because "Other info" is part of "Minimum ratio"

-### Other info
+## Other info

@dzc34 dzc34 closed this Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzc34 dzc34 dzc34 left review comments

Assignees
No one assigned
Labels
a11y doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnaudDelafosse @dzc34