Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vulnerable Packages #59

Closed
wants to merge 2 commits into from

Conversation

RogerBarreto
Copy link

When attempting to use the package some vulnerabilities starting to show up in the IDE.

image

@Swimburger
Copy link
Contributor

We have reported this as an issue in OneOf mcintyre321/OneOf#190

But if the C# SDK is regenerated with the latest C# SDK generator from Fern, these vulnerabilities should be resolved.

@marcusolsson can we work together on upgrading the C# SDK generator?

@RogerBarreto
Copy link
Author

@Swimburger this PR also removes the transitive and add the packages as direct dependencies which are .Net ones, this can be a simpler approach to solve the vulnerability problem, let me know if this is bad for you, and if it is I just close this down.

@Swimburger
Copy link
Contributor

@RogerBarreto, this is essentially what the latest C# generator would generate, so I don't see why we shouldn't merge this.
@marcusolsson this change looks good to me, can we merge it?

@Swimburger
Copy link
Contributor

@RogerBarreto can you increment that patch version of this library?
Search and replace all 1.2.0 with 1.2.1 essentially :)

@marcusolsson
Copy link
Contributor

Thank you @RogerBarreto for reporting 🙏

I've created #61 with the latest Fern generator. I'll focus on getting it merged first, and then come back to this PR if it isn't addressed by the new release.

@RogerBarreto
Copy link
Author

Dropping this PR as the following one resolved. it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants