Cleaning and commenting Dockerfiles

AstroPlant · Sep 14, 2020 · b911ccf · b911ccf
1 parent 07e10b0
commit b911ccf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 19 deletions.
diff --git a/Dockerfile b/Dockerfile
diff --git a/Dockerfile.production b/Dockerfile.production
@@ -1,3 +1,6 @@
+# Dockerfile used to create the production image
+# Environment variables are set inside the Kubernetes cofiguration files
+
 FROM node:12-alpine
 
 # Create app directory

diff --git a/api/Dockerfile b/api/Dockerfile
@@ -1,3 +1,6 @@
+# Dockerfile used in the main docker compose to create the image of the API
+# Environment variables and start commands are handled inside the docker compose
+
 FROM strapi/base
 
 # Create app directory

diff --git a/api/Dockerfile.production b/api/Dockerfile.production
@@ -1,3 +1,6 @@
+# Dockerfile used to create the production image
+# Environment variables are set inside the Kubernetes cofiguration files
+
 FROM strapi/base
 
 # Create app directory
@@ -19,6 +22,7 @@ ENV DATABASE_PORT=5432
 ENV DATABASE_NAME=strapi
 ENV DATABASE_USERNAME=
 ENV DATABASE_PASSWORD=
+ENV PRODUCTION_URL=
 ENV ADMIN_JWT_SECRET=
 
 RUN npm run build

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -1,3 +1,5 @@
+# Docker compose files used for dev environments
+
 version: "3.8"
 
 services: