Skip to content

Commit

Permalink
just process exit (#205)
Browse files Browse the repository at this point in the history
<!-- CLICK "Preview" FOR INSTRUCTIONS IN A MORE READABLE FORMAT -->

## Proposed changes

Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug 
or resolves a feature request, be sure to link to that issue.

## Types of changes

What types of changes does your code introduce?

_Put an `x` in the boxes that apply_

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

## Checklist

_Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to
ask.
We're here to help! This is simply a reminder of what we are going to
look
for before merging your code._

- [ ] I have read the
[CONTRIBUTING](https://github.com/AthennaIO/Core/blob/master/CONTRIBUTING.md)
documentation
- [ ] Lint and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added necessary documentation (if appropriate)

## Further comments

If this is a relatively large or complex change, kick off the discussion
by
explaining why you chose the solution you did and what alternatives you 
considered, etc...
  • Loading branch information
jlenon7 authored Jan 6, 2024
1 parent cb14e11 commit 069fdb3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@athenna/core",
"version": "4.19.0",
"version": "4.20.0",
"description": "The plug and play Node.js framework.",
"license": "MIT",
"author": "João Lenon <[email protected]>",
Expand Down
2 changes: 0 additions & 2 deletions src/repl/ReplImpl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
* file that was distributed with this source code.
*/

import { LoadHelper } from '#src/helpers/LoadHelper'
import type { Command } from '#src/repl/helpers/Command'
import type { REPLServer, ReplOptions } from 'node:repl'
import { Is, Module, Options, String } from '@athenna/common'
Expand Down Expand Up @@ -47,7 +46,6 @@ export class ReplImpl {
*/
public shutdownProviders() {
this.session?.on('exit', async () => {
await LoadHelper.shutdownProviders()
process.exit(0)
})

Expand Down

0 comments on commit 069fdb3

Please sign in to comment.