This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Force elixirc for umbrella projects #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
approved these changes
Jul 19, 2017
mauricerkelly
deleted the
mauricerkelly/force-elixirc-for-umbrella-projects
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the changes for an intermediary resolution to the problems raised in Issue #96.
For now it's not possible to correctly determine the file path within an umbrella project that contains errors when using Mix (via
mix compile). While a full solution is being sought, I've changed the conditional that determines which compiler path to take so that umbrella projects will always be compiled withelixircinstead ofmix compileIt is not possible to add unit tests for this due to the limitations of performing Mix-based testing.