early return on empty buffer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #2
My understanding of Metal programming is nascent so please excuse any false presumptions. But from my understanding an early return will solve the issue. In an intensive metal application this might cause some frame skips but in the charting/plotting context I think this will be ok.
Preferably we'd have some sort of feedback up the chain about what caused the error but in the meantime this resolved the issue for my testers.
Notably this issue only happened on iOS 15.6.1 and on an iPhone 12 mini. All the other devices worked perfectly. So it may be an issue with older/slower hardware not having the buffers prepped In time? (I can't believe I'm considering the iPhone 12 old it feels like it just came out yesterday!)