Add support for other post types #223 #342

shantanu2704 · 2018-01-18T06:31:11Z

Added a static variable for supported post types that can be filtered with the 'modify_supported_post_types' filter in the init() method.
Added support for 'pages' in the init() method.

…the core plugin file

pyronaur

Thank you for the pull request! I noted some things that I think need some more thought.

pyronaur · 2018-01-19T08:56:36Z

.gitignore

@@ -7,6 +7,7 @@ yarn-error.log
 .svn
 composer.lock
 vendor/
+/nbproject


I recommend that you add the /nbrpoject to your global gitignore, that way you won't have to add it to the project. Or you can move it to where the .idea folder is ignored

pyronaur · 2018-01-19T08:59:16Z

liveblog.php

 		 */
-		add_post_type_support( 'post', self::key );
+		self::$supported_post_types = apply_filters( 'modify_supported_post_types', $post_types );


Filters have to be prefixed. Some useful info here.

pyronaur · 2018-01-19T09:00:17Z

liveblog.php

@@ -451,14 +461,14 @@ public static function is_liveblog_post( $post_id = null ) {
 	 * @return bool
 	 */
 	public static function is_viewing_liveblog_post() {
-		return (bool) ( is_single() && self::is_liveblog_post() );
+		return (bool) ( is_singular() && self::is_liveblog_post() );


This will return true for all post types, including unsupported post types. This needs more precision. Also, possibly a filter - not sure.

is_singular will return true for all default single post types.
Correct me if I am wrong, but for it to return true on a custom post type, the name of the custom post type needs to be sent as a parameter.

Also, how do you think this conditional should be handled?

https://codex.wordpress.org/Function_Reference/is_singular#Custom_Post_Types

is_singular by default will check if any post type is singular, not just post or pages. So you have to check the is_signular() against all of the post types that support LIveblog.

pyronaur · 2018-01-19T09:00:39Z

liveblog.php

 	}

 	/**
 	 * One of: 'enable', 'archive', false.
 	 */
 	public static function get_liveblog_state( $post_id = null ) {
-		if ( ! is_single() && ! is_admin() && ! self::$is_rest_api_call) {
+		if ( !is_singular() && ! is_admin() && ! self::$is_rest_api_call) {


Same as above - needs more precision.

I think we could use get_post_type() here.
https://developer.wordpress.org/reference/functions/get_post_type/

Something like:
...
if ( !is_singular( get_post_type( $post_id ) ) ... )

is_singular will accept post types as the parameter. You can pass the static $supported_post_types variable to the function instead.

pyronaur · 2018-01-19T09:02:35Z

liveblog.php

@@ -57,6 +57,8 @@
 	public static $is_rest_api_call       	= false;
 	public static $auto_archive_days     	= null;
 	public static $auto_archive_expiry_key  = 'liveblog_autoarchive_expiry_date';
+
+	public static $supported_post_types = array();


Why is a static variable better here than a regular class variable?

The init method is static. As far as I know PHP doesn't allow non-static members to be accessed in a static method.

Ahh, you're right - the is_liveblog_post() method is static too and it's going to rely on this.

pyronaur · 2018-01-22T07:45:12Z

liveblog.php

@@ -245,7 +245,7 @@ public static function init() {
 		/**
 		 * This allows the users to filter their supported post types.
 		 */
-		self::$supported_post_types = apply_filters( 'modify_supported_post_types', $post_types );
+		self::$supported_post_types = apply_filters( 'liveblog_modify_supported_post_types', $post_types );


Can you remove the modify from the filter? I think that would be better because it would almost look like the variable name we're already using: liveblog_supported_post_types

pyronaur · 2018-01-22T07:46:09Z

Changes looking good! I think we need just a few more tweaks and we're good to go.

shantanu2704 · 2018-01-23T07:18:04Z

Hey @justnorris, I was wondering if you had a chance to look at the tests that are failing. I could use a little help there

pyronaur · 2018-01-23T07:21:32Z

Have a look at the test logs - could it be that your tests issue is related to #344 ?

shantanu2704 · 2018-01-23T07:28:47Z

It could be.
The two tests that are failing, expect the HTTP error code 403 but are getting the HTTP error code 401.

pyronaur · 2018-01-23T19:24:42Z

In that case, I think we can wait until the tests are pulled in the master branch - then you can update your pull request to make sure the tests pass.

shantanu2704 · 2018-01-24T03:52:31Z

That sounds good. Thanks, Norris!

shantanu2704 · 2018-01-25T07:53:10Z

Hey @justnorris!
#344 has been merged. Is there a way to check if the tests that were previously failing are still failing or do they pass?

pyronaur · 2018-01-25T07:56:45Z

You can pull the master branch in your pull request branch - that should update everything and make the tests run again.

pyronaur · 2018-02-02T12:14:16Z

I think this looks good! /cc @philipjohn

GaryJones · 2018-08-07T15:28:21Z

This PR has a merge conflict.

philipjohn

Thanks for this @shantanu2704! Could you take a look at my one inline comment and the merge conflict please? Then I think we can include this in v2.0 :)

philipjohn · 2018-10-08T09:34:35Z

liveblog.php

-		 * we can possibly introduce this to other post types later.
+		 * Add liveblog support to the 'post' and 'page' post type.
+		 */		
+		$post_types = array( 'post', 'page' );


If I understand correctly, this will also add support for pages out of the box? I'd rather we just stick to posts, and allowing pages to be added using the filter.

shantanu2704 · 2018-10-08T12:19:52Z

Hey @philipjohn! Thanks for the feedback!
Sadly, the changes made for this PR are long gone.
So I have submitted a new PR - #539 - which, along with the changes from this PR, incorporates your feedback, re the post type page.

Closing out this PR in favour of #539 :)

shantanu2704 added 9 commits January 14, 2018 19:06

Add nbproject to git ignore

cd814f1

Add post type support for page, attachment and revision in init() of …

43dd4de

…the core plugin file

Add checks for page and attachment when checking for liveblog post

b7a457e

Use is_singular instead of multiple is_* checks

a8876f0

Update get_liveblog_state

6e8d31c

Remove support for revision type

094727a

Remove support for attachment type

6cfe394

Add a new filter to allow the user to filter the supported post types

6ea2457

Fix declarations

b08da6c

shantanu2704 mentioned this pull request Jan 18, 2018

Add support for other post types #223

Open

shantanu2704 added 3 commits January 18, 2018 15:15

Add ruleset

6675564

Try adding a conditional to the url endpoint

b69ec27

Revert last commit

0c42d8c

pyronaur requested changes Jan 19, 2018

View reviewed changes

shantanu2704 added 3 commits January 22, 2018 10:47

Remove /nbproject from gitignore

69bafc4

Add a 'liveblog' prefix to the filter name

3773a49

Remove phpcs.xml.dist which was added by mistake

becefb7

pyronaur reviewed Jan 22, 2018

View reviewed changes

shantanu2704 added 2 commits January 22, 2018 14:42

Refine the is_singular() conditional

7bc535f

Fix formatting

7ee23c4

shantanu2704 added 2 commits January 25, 2018 13:32

Merge branch 'master' of github.com:Automattic/liveblog

7bb33b3

Merge branch 'master' of github.com:automattic/liveblog

9f6e3a1

pyronaur approved these changes Feb 2, 2018

View reviewed changes

philipjohn added Type: enhancement Priority::Medium labels Oct 8, 2018

philipjohn suggested changes Oct 8, 2018

View reviewed changes

shantanu2704 mentioned this pull request Oct 8, 2018

Add support for other post types #539

Open

shantanu2704 closed this Oct 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for other post types #223 #342

Add support for other post types #223 #342

shantanu2704 commented Jan 18, 2018

pyronaur left a comment

pyronaur Jan 19, 2018

pyronaur Jan 19, 2018

pyronaur Jan 19, 2018

shantanu2704 Jan 21, 2018

shantanu2704 Jan 22, 2018

pyronaur Jan 22, 2018

pyronaur Jan 19, 2018

shantanu2704 Jan 22, 2018

pyronaur Jan 22, 2018

pyronaur Jan 19, 2018

shantanu2704 Jan 21, 2018 •

edited

Loading

pyronaur Jan 22, 2018

pyronaur Jan 22, 2018

pyronaur commented Jan 22, 2018

shantanu2704 commented Jan 23, 2018

pyronaur commented Jan 23, 2018

shantanu2704 commented Jan 23, 2018

pyronaur commented Jan 23, 2018

shantanu2704 commented Jan 24, 2018

shantanu2704 commented Jan 25, 2018

pyronaur commented Jan 25, 2018

pyronaur commented Feb 2, 2018

GaryJones commented Aug 7, 2018

philipjohn left a comment

philipjohn Oct 8, 2018

shantanu2704 commented Oct 8, 2018

Add support for other post types #223 #342

Add support for other post types #223 #342

Conversation

shantanu2704 commented Jan 18, 2018

pyronaur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shantanu2704 Jan 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pyronaur commented Jan 22, 2018

shantanu2704 commented Jan 23, 2018

pyronaur commented Jan 23, 2018

shantanu2704 commented Jan 23, 2018

pyronaur commented Jan 23, 2018

shantanu2704 commented Jan 24, 2018

shantanu2704 commented Jan 25, 2018

pyronaur commented Jan 25, 2018

pyronaur commented Feb 2, 2018

GaryJones commented Aug 7, 2018

philipjohn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shantanu2704 commented Oct 8, 2018

shantanu2704 Jan 21, 2018 •

edited

Loading