Parse font using parse-css-font and units-css #891
Conversation
|
Always hated that regex, appreciate this! Have you tried creating a test program in C which calls Pango and asks for a small-caps font? The example code here is easy to modify to test things like that... I have found a lot of holes in support for less-used features like this in OSX and Windows. Or it might only work on TTFs that identify as a small caps variant, I don't know if Pango will do the "fake" small caps that browsers do |
|
Hi @chearon. Thank you. I wasn't sure whether there's some policy in this project against using external packages. I haven't tried yet to create a test program. I might have some time to do that over the weekend. Anyway, I think the pull request has value even without implementing the actual rendering of font variants, because it parses the font style correctly and doesn't fall back to a default size when the variant is included. |
I'm all for using external packages 👍 the less code we have the better 🎉 |
Parse font using parse-css-font and units-css
|
Released as v1.6.5 |
|
Thank you! :) I'll create a new issue for the problem with small-caps in pango |
This pull request address issue #566
My issue was in using
node-canvasto test code that usespixi.js, which always specifies fully the style, variant and weight inctx.font, and currently it falls back to the default size.The problem seems to be in the parsing of the font style. I found the modules parse-css-font and units-css that provide functions to parse the font style and could be used as a drop in replacement to the current code. Both modules are shipped with the MIT license, so I don't think that this dependency should be an issue.
The
font-variantproperty is currently not passed to theccode and not processed bypango. I managed to implement this, but still couldn't getpangoto render "small-caps" (see my branch font-variant). In the meantime, I am only sharing in this pull-request the solution for the font style parsing issue.