Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable first line title parsing for Firefox #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkaz
Copy link
Contributor

@mkaz mkaz commented Dec 18, 2019

This PR removes the check for Firefox that disables first line title parsing.
The reasoning of not supporting ::first-line is no longer valid.
https://caniuse.com/#feat=css-first-line

Test:

  1. Apply PR
  2. Add new post with a suitable first line title
  3. Confirm title is added as an H1 to the post, and set in wp-admin

@mkaz
Copy link
Contributor Author

mkaz commented Dec 18, 2019

Correction: The first-line selector does not work within a Textarea in Firefox. So the formatting can not be displayed. The parsing of the title in the first line does work, but is not shown visually from within the textarea on Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant