Move preview capability checks into the specific preview handlers. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the capability checks for comment previewing away from
edit_posts. These were added in #205.Example: Attempt to preview a comment on make.wordpress.org/meta/ from a user who is not a member of the site (or cannot edit posts).
This requires a security review of some form, I believe it should be safe, but needs to be reviewed to ensure that the same comment_text-sanitization that occurs on comment post is applied here during preview.
For example, posting
<script>alert(1)</script>should not work in the preview.See #215