Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Don't load if not loaded #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 26, 2024

I don't really know why this happens, but ready.o2 fires after preload.o2, but the ready.o2 hook is fired before the preload.o2 hook has run too.

I assume this is because o2 is assuming that ready.o2 is unique to o2, but actually it's just a namespaced variant of ready, so document ready triggers it, and then o2 triggers it.

15:20:23.374 notifications.js?ver=6.5-beta2-57697:81 ready.o2 without notifs
15:20:23.403 notifications.js?ver=6.5-beta2-57697:76 preload.o2
15:20:23.432 notifications.js?ver=6.5-beta2-57697:81 ready.o2 with notifs

Fixes #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read properties of undefined (reading 'open')
1 participant