Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar compression regression #10

Open
JanJakes opened this issue Feb 10, 2025 · 0 comments · May be fixed by #11
Open

Fix grammar compression regression #10

JanJakes opened this issue Feb 10, 2025 · 0 comments · May be fixed by #11

Comments

@JanJakes
Copy link
Contributor

There is a small regression in the grammar processing script:

The PHPized grammar now contains array indexes of the main rules, while previously they were not listed. It seems there are numeric gaps. It might be a regression caused when manually parsing the grammar. I suppose it's an easy fix.

This makes the compressed grammar a bit larger, as it includes array indexes that don't need to be indexed.

@JanJakes JanJakes linked a pull request Feb 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant