Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar compression #11

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix grammar compression #11

wants to merge 1 commit into from

Conversation

JanJakes
Copy link
Contributor

This fixes the following regression:

The PHPized grammar now contains array indexes of the main rules, while previously they were not listed. It seems there are numeric gaps. It might be a regression caused when manually parsing the grammar. I suppose it's an easy fix.

Fixes #10.

@JanJakes
Fix grammar compression regression causing array index gaps
b95341e 
The grammar expansion code caused duplicit entries for expanded rules
that are used in multiple different entries. When creating an index of the
grammar rules, this caused array index gaps, converting a list array to an
associative array with indexes included in the compressed grammar.
@JanJakes JanJakes force-pushed the fix-grammar-compression branch from 12a1b00 to b95341e Compare February 10, 2025 09:18
@JanJakes JanJakes changed the base branch from develop to ast-sqlite-driver February 10, 2025 09:18
Base automatically changed from ast-sqlite-driver to develop February 12, 2025 09:42
@JanJakes JanJakes requested a review from adamziel February 12, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamziel adamziel Awaiting requested review from adamziel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix grammar compression regression
1 participant
@JanJakes