Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch telemetry library loading to plain require_once #5891

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Sep 26, 2024

Description

Follow up to #5869. Let's remove the loop and use plain require_once.

Please only merge it after the library is fully deployed.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.53%. Comparing base (04ceae6) to head (b4a844e).
Report is 63 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5891      +/-   ##
=============================================
+ Coverage      30.51%   30.53%   +0.01%     
  Complexity      4811     4811              
=============================================
  Files            289      289              
  Lines          21173    21161      -12     
=============================================
  Hits            6461     6461              
+ Misses         14712    14700      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanmai sanmai requested a review from ingeniumed September 26, 2024 23:55
@sanmai sanmai marked this pull request as ready for review September 27, 2024 06:27
@sanmai sanmai requested a review from a team as a code owner September 27, 2024 06:27
@rinatkhaziev
Copy link
Contributor

needs to wait for 1 release cycle.

@sjinks
Copy link
Member

sjinks commented Nov 26, 2024

@rinatkhaziev is this one good to go now?

Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Copy link

sonarqubecloud bot commented Feb 6, 2025

@sjinks sjinks merged commit a3b0777 into develop Feb 6, 2025
26 of 32 checks passed
@sjinks sjinks deleted the fix/telemetry-require-once branch February 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants