Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hover to WooPayments Payment Method logos component #10091

Closed
timmy5685 opened this issue Jan 6, 2025 · 3 comments · Fixed by #10167
Closed

Add hover to WooPayments Payment Method logos component #10091

timmy5685 opened this issue Jan 6, 2025 · 3 comments · Fixed by #10167
Assignees
@elazzabi
Labels
focus: account lifecycle
Milestone
WooPayments 8.9.0

Comments

@timmy5685
Copy link

timmy5685 commented Jan 6, 2025 •
edited
Loading

Description

Enhance the existing WooPayments payment method logo component (#8808 & #8977) to include a hover state over the additional payment methods so merchants can see the full list of methods supported by WooPayments. This enhancement was added as part of the new NOX experience.

Acceptance criteria

  • Hovering over the +10, +13, & +15 tiles expands to show the remaining payment methods as indicated by the displayed number.

Designs

Figma: https://www.figma.com/design/Kofpo8jj4zDWXDsVdlSz0f/WooCommerce-Admin-Design-Library?node-id=8695-800&t=Ra0VDsL5U0Tw5IcX-0

Additional Context

#54210 for related WooCommerce update
@timmy5685 timmy5685 mentioned this issue Jan 6, 2025
Closed
@anu-rock
Copy link
Contributor

anu-rock commented Jan 7, 2025

@timmy5685 We already had #9929, but yours is better fleshed out. I'll close the other one in favor of this.

@anu-rock
Copy link
Contributor

anu-rock commented Jan 7, 2025

Also, double-checking the intended behavior on mobile. I think by default mobile browsers handle hovers with tap.

@anu-rock anu-rock marked this as a duplicate of #9929 Jan 7, 2025
@elazzabi elazzabi self-assigned this Jan 10, 2025
@orcungogus
Copy link

@anu-rock, as you mentioned we can show the hover state with a tap on mobile!

@elazzabi elazzabi mentioned this issue Jan 16, 2025
Merged
6 tasks
@anu-rock anu-rock added this to the WooPayments 8.9.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elazzabi elazzabi

Labels
focus: account lifecycle
Projects
None yet
Milestone
WooPayments 8.9.0
Development

Successfully merging a pull request may close this issue.

Add a popover to WooPayments to present all possible payment methods Automattic/woocommerce-payments
4 participants
@anu-rock @elazzabi @timmy5685 @orcungogus