Add a popover to WooPayments to present all possible payment methods #10167
+616
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +2.48 kB (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Looks good to me, great job @elazzabi! |
mordeth
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thank you for working on this, Ahmed!
✅ Code changes are looking good!
❌ Hovering over the +10 button displays the logos, but the popup closes when the cursor moves over it. That doesn't happen on WooCommerce -> Settings -> Payments.
Additionally, on a JN site, the logos appear in a single line, whereas they display correctly on the local environment.
6 tasks
|
@elazzabi also, could you please fix JS linting errors before merging, thanks! |
I'm pretty sure that's because we are using an old
Interesting, I can replicate it. I'm not sure why it's not showing locally 🤔 looking... |
…/woocommerce-payments into add/popover-extra-pms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10091
These changes are made to match what we have in Core woocommerce/woocommerce#54404
Changes proposed in this Pull Request
This PR adds a popover to WooPayments presentation to present all possible payment methods
Testing instructions
Force the WCPay plugin to act as disconnected from the Transact Platform ServerSome encountered problems:
Popovercomponent isn't responding to theplacementprop. I tried to change it multiple times, but for some reason, it's not working...<img>tags)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge