-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the Order Full Refund spec to Playwright #10151
base: develop
Are you sure you want to change the base?
Convert the Order Full Refund spec to Playwright #10151
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are passing, but I encountered a scenario where the first step of deactivating multi-currency could lead to flaky tests.
|
||
// Disable multi-currency in the merchant settings. This step is important because local environment setups | ||
// might have multi-currency enabled. We need to ensure a consistent environment for the test. | ||
await deactivateMulticurrency( merchantPage ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be a good idea to check if multi-currency is enabled before proceeding? I’m mentioning this because the test fails when multi-currency is already disabled.
Alternatively, we could skip this step if the save button is disabled. I believe the Playwright version of those helpers behaves a bit differently and doesn’t include that extra check for the save button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing it, I initially missed the issue while dealing with the support phone thing. I think it's better to check if it's active instead of skipping the save button when it's disabled to avoid missing any 0981fae
Fixes #9961
Changes proposed in this Pull Request
merchant-orders-full-refund-spec
from Puppeteer to Playwright.TODO
.Testing instructions
dev/9961-convert-merchant-orders-full-refund-spec
npm run test:e2e-pw merchant-orders-full-refund-spec
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge