fix: ECE initialization when no shipping rates are provided #10169
+238
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
requested review from
a team and
FangedParakeet
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
commented
Jan 16, 2025
| @@ -33,8 +35,6 @@ export const shippingAddressChangeHandler = async ( api, event, elements ) => { | |||
| amount: response.total.amount, | |||
| } ); | |||
|
|
|||
| lastSelectedAddress = event.address; | |||
There was a problem hiding this comment.
Moved above, so that the newly selected address is saved regardless of the error.
This makes the behavior consistent between block-based and shortcode-based checkout.
Comment on lines
-76
to
-84
| const shippingRates = requestShipping | ||
| ? [ | ||
| { | ||
| id: 'pending', | ||
| displayName: __( 'Pending', 'woocommerce-payments' ), | ||
| amount: 0, | ||
| }, | ||
| ] | ||
| : undefined; |
There was a problem hiding this comment.
This "Pending" rate is now consistently added on initialization. Before, it was added only on the product pages.
|
Size Change: +95 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9939
Fixes #9593
Changes proposed in this Pull Request
When the "Hide shipping costs until an address is entered" option is checked, WooCommerce checkout requires a country/state/zipcode/city address to get shipping rates.
This scenario was incompatible with the ECE initialization.
You see, when we click on the ECE button, we tell Stripe: "Please initialize the ECE dialog with the possibility to select shipping rates.". In this scenario, Stripe requires us to provide some shipping rates.
But, unfortunately, if the product is physical and the "Hide shipping costs until an address is entered" option is selected in the WC settings and the customer hasn't visited the checkout before, we get in a bit of a pickle: we ask Stripe to initialize the ECE dialog with the possibility of showing shipping rates. But we don't have any initial shipping rates - and Stripe gets angry at us, erroring out with this message and with a partially initialized ECE:
I implemented these changes for both the tokenized ECE and non-tokenized ECE, where possible.
The non-tokenized ECE changes were slightly more complex (due to the server-side response we "hack"), so I didn't think it was worth spending more time on it.
Testing instructions
I also simulated this scenario when there are no shipping rates available for a given customer. I did so by adding a "US - California" shipping zone (in the WooCommerce Shipping settings), and ensuring it doesn't have any rates. Then, as an anonymous customer, you can click on the ECE button again. The ECE will prompt you to select a different address.
Here's an example with ApplePay:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge