-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Shopper Checkout Purchase spec to Playwright #10198
Merged
ismaeldcom
merged 5 commits into
develop
from
dev/10177-convert-shopper-checkout-purchase-spec
Jan 22, 2025
Merged
Convert Shopper Checkout Purchase spec to Playwright #10198
ismaeldcom
merged 5 commits into
develop
from
dev/10177-convert-shopper-checkout-purchase-spec
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
tpaksu
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is understandable and clean, tests well both on local and remote, LGTM. !
@ismaeldcom I think this will close 10065, not 10177 btw. Correct? |
True! nice catch, I messed it up while copying the other PR ID for the existing code reference 😅 |
ismaeldcom
deleted the
dev/10177-convert-shopper-checkout-purchase-spec
branch
January 22, 2025 09:02
dmvrtx
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10065
Changes proposed in this Pull Request
Convert the
shopper-checkout-purchase
spec from Puppeteer to Playwright.This PR includes a copy of
expectFraudPreventionToken
already implemented in a previous PR.Testing instructions
dev/10177-convert-shopper-checkout-purchase-spec
npm run test:e2e-pw shopper-checkout-purchase
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge