-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev - Upgrade to Node v20 #9121
Conversation
…h the app and unit tests
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!! 💯 Those snapshot updates are 🤢 I think we should move away from using snapshots.
Looks like an additional update is needed on this action - we should be able to just use the latest version: https://github.com/Automattic/woocommerce-payments/blob/bd5fa2793ec195315d3a2f21bc0157c413d6a8ba/.github/workflows/bundle-size.yml
Tested locally in settings/disputes/checkout/etc. I didn't notice any differences.
Thank you for working on this!
} ); | ||
|
||
expect( handleHideMock ).toHaveBeenCalled(); | ||
|
||
act( () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about this change - why did the expect get moved from the end to the middle here? Just to be closer to the click
action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it wasn't necessary, the only necessary change was to wrap the runAllTimers call in a separate act()
block. I'll revert that small change.
* External dependencies | ||
*/ | ||
import { Status } from '@wordpress/notices'; | ||
// This type was imported from @wordpress/notices but it's not longer exported by the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the inline comment 👍
Fixes #9116
Changes proposed in this Pull Request
@woocommerce/components
and@wordpress/scripts
. Other packages related to testing and linting were also updated.Testing instructions
npm build
,npm start
,npm lint
,npm test:js
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge