fix(slimfaas): log kubernetes

AxaFrance · Jan 14, 2025 · 83500bf · 83500bf
1 parent eaed9fb
commit 83500bf
Showing 1 changed file with 4 additions and 21 deletions.
diff --git a/src/SlimFaas/Kubernetes/KubernetesService.cs b/src/SlimFaas/Kubernetes/KubernetesService.cs
@@ -231,23 +231,6 @@ public async Task<DeploymentsInformations> ListFunctionsAsync(string kubeNamespa
         }
     }
 
-    private static IList<int> ReadRetryAnnotation( IDictionary<string, string>? annotations)
-    {
-        if (annotations != null && annotations.TryGetValue(AsynchrounousRetry, out string? valueAsynchrounousRetry))
-        {
-            var result = new List<int>();
-            var array = valueAsynchrounousRetry.Split(';');
-            foreach (string s in array)
-            {
-                result.Add( int.Parse(s, NumberStyles.Integer));
-            }
-
-            return result;
-        }
-
-        return new List<int>(){2, 4, 8};
-    }
-
     private static async Task AddDeployments(string kubeNamespace, V1DeploymentList deploymentList, IEnumerable<PodInformation> podList,
         IList<DeploymentInformation> deploymentInformationList, ILogger<KubernetesService> logger, k8s.Kubernetes client , IList<DeploymentInformation> previousDeploymentInformationList)
     {
@@ -267,7 +250,7 @@ private static async Task AddDeployments(string kubeNamespace, V1DeploymentList
                 ScheduleConfig? scheduleConfig = GetScheduleConfig(annotations, name, logger);
                 SlimFaasConfiguration configuration = GetConfiguration(annotations, name, logger);
                 var previousDeployment = previousDeploymentInformationList.FirstOrDefault(d => d.Deployment == name);
-                bool endpointReady = await GetEndpointReady(kubeNamespace, client, previousDeployment, name, pods);
+                bool endpointReady = await GetEndpointReady(logger, kubeNamespace, client, previousDeployment, name, pods);
                 var resourceVersion = $"{deploymentListItem.Metadata.ResourceVersion}-{endpointReady}";
                 if (previousDeployment != null && previousDeployment.ResourceVersion ==  resourceVersion)
                 {
@@ -320,7 +303,7 @@ private static async Task AddDeployments(string kubeNamespace, V1DeploymentList
         }
     }
 
-    private static async Task<bool> GetEndpointReady(string kubeNamespace, k8s.Kubernetes client,
+    private static async Task<bool> GetEndpointReady(ILogger<KubernetesService> logger, string kubeNamespace, k8s.Kubernetes client,
         DeploymentInformation? previousDeployment, string name, List<PodInformation> pods)
     {
         try
@@ -349,7 +332,7 @@ private static async Task<bool> GetEndpointReady(string kubeNamespace, k8s.Kuber
         }
         catch (Exception e)
         {
-            Console.WriteLine(e);
+            logger.LogDebug("Error while getting endpoint ready {Name} : {Exception}", name, e.ToString());
         }
         return false;
     }
@@ -407,7 +390,7 @@ private static async Task AddStatefulSets(string kubeNamespace, V1StatefulSetLis
                 ScheduleConfig? scheduleConfig = GetScheduleConfig(annotations, name, logger);
                 SlimFaasConfiguration configuration = GetConfiguration(annotations, name, logger);
                 var previousDeployment = previousDeploymentInformationList.FirstOrDefault(d => d.Deployment == name);
-                bool endpointReady = await GetEndpointReady(kubeNamespace, client, previousDeployment, name, pods);
+                bool endpointReady = await GetEndpointReady(logger, kubeNamespace, client, previousDeployment, name, pods);
                 var resourceVersion = $"{deploymentListItem.Metadata.ResourceVersion}-{endpointReady}";
                 if (previousDeployment != null && previousDeployment.ResourceVersion ==  resourceVersion)
                 {