Skip to content

Commit

Permalink
Add concern on simulation times.
Browse files Browse the repository at this point in the history
  • Loading branch information
just-mitch committed Jun 18, 2024
1 parent fdc4aef commit 2acf140
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions in-progress/6973-refactor-base-contract-interaction.md
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,10 @@ export class BinarySearchGasEstimator implements GasEstimator {

### Concerns

#### Long time to simulate for gas estimation

The binary search proposed in the gas estimation algorithm could add a lot of time needed for simulation. If/when we find this to be the case, we could impose an interface on FPCs to provide more information around how much gas the use of that FPC is going to cost, though the exact mechanism here is a bit unclear.

#### `UserRequest` is a kitchen sink

The `UserRequest` object is a bit of a kitchen sink. It might be better to have a `DeployRequest`, `CallRequest`, etc. that extends `UserRequest`.
Expand Down

0 comments on commit 2acf140

Please sign in to comment.