maybe it doesnt even need continue on error? bah

AztecProtocol · Dec 21, 2023 · 4a2d6bf · 4a2d6bf
1 parent 860723d
commit 4a2d6bf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/.github/workflows/vite_hardhat_nightly.yaml b/.github/workflows/vite_hardhat_nightly.yaml
@@ -49,19 +49,16 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Set up yarn
-        continue-on-error: true
         uses: ./.github/actions/setup-yarn
         with:
           project: vite-hardhat
 
       - name: Set up nargo
-        continue-on-error: true
         uses: ./.github/actions/setup-nargo
         with:
           version: ${{ matrix.version }}
 
       - name: Get stability
-        continue-on-error: true
         id: get-stability
         env:
           VERSIONS_MAP: ${{ needs.vite-hardhat-setup.outputs.versions_map }}
@@ -79,7 +76,6 @@ jobs:
           echo "::set-output name=is_stable::$IS_STABLE"
 
       - name: Install test version
-        continue-on-error: true
         run: |
           yarn add \
           @noir-lang/noir_js@${{ matrix.version }} \
@@ -88,7 +84,6 @@ jobs:
           @noir-lang/types@${{ matrix.version }}
 
       - name: 'Create env file'
-        continue-on-error: true
         run: |
           touch .env
           echo SEPOLIA_ALCHEMY_KEY="${{ secrets.SEPOLIA_ALCHEMY_KEY }}" >> .env
@@ -97,13 +92,11 @@ jobs:
           echo MUMBAI_DEPLOYER_PRIVATE_KEY="${{ secrets.MUMBAI_DEPLOYER_PRIVATE_KEY }}" >> .env
 
       - name: Generate verifier contract
-        continue-on-error: true
         run: |
           nargo codegen-verifier
         working-directory: vite-hardhat/circuits
 
       - name: Run test
-        continue-on-error: true
         run: yarn test
         id: yarn_test
 

diff --git a/.github/workflows/with_foundry_nightly.yaml b/.github/workflows/with_foundry_nightly.yaml
@@ -47,17 +47,14 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Set up nargo
-        continue-on-error: true
         uses: ./.github/actions/setup-nargo
         with:
           version: ${{ matrix.version }}
 
       - name: Set up foundry
-        continue-on-error: true
         uses: ./.github/actions/setup-foundry
 
       - name: Get stability
-        continue-on-error: true
         id: get-stability
         env:
           VERSIONS_MAP: ${{ needs.with-foundry-setup.outputs.versions_map }}
@@ -75,7 +72,6 @@ jobs:
           echo "::set-output name=is_stable::$IS_STABLE"
 
       - name: Install test version
-        continue-on-error: true
         run: |
           yarn add \
           @noir-lang/noir_js@${{ matrix.version }} \
@@ -84,26 +80,22 @@ jobs:
           @noir-lang/types@${{ matrix.version }}
 
       - name: 'Create env file'
-        continue-on-error: true
         run: |
           touch .env
           echo LOCALHOST_PRIVATE_KEY="${{ secrets.LOCALHOST_PRIVATE_KEY }}" >> .env
           echo ANVIL_RPC="${{ secrets.ANVIL_RPC }}" >> .env
 
       - name: Generate verifier contract
-        continue-on-error: true
         run: |
           nargo codegen-verifier
         working-directory: with-foundry/circuits
 
       - name: Generate proof
-        continue-on-error: true
         run: |
           nargo prove
         working-directory: with-foundry/circuits
 
       - name: Test with Foundry
-        continue-on-error: true
         run: |
           forge test --optimize --optimizer-runs 5000 --evm-version london